gnark-crypto icon indicating copy to clipboard operation
gnark-crypto copied to clipboard

fix comment of v for `SetBigInt`

Open zhiqiangxu opened this issue 1 year ago • 1 comments

We can only conclude v >= 0 instead of v > 0 from v.Cmp(&zero) != -1.

zhiqiangxu avatar Sep 19 '24 13:09 zhiqiangxu

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 19 '24 13:09 CLAassistant

Thanks for the contribution! I also code generated the implementation for all curves. I'll merge to a branch which collects all documentation fixes which we merge before next release.

ivokub avatar Dec 04 '24 00:12 ivokub