gnark-crypto icon indicating copy to clipboard operation
gnark-crypto copied to clipboard

chore: fix some function names

Open drawdrop opened this issue 1 year ago • 1 comments

Description

fix some function names

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How has this been tested?

Please describe the tests that you ran or implemented to verify your changes. Provide instructions so we can reproduce.

  • [ ] Test A
  • [ ] Test B

How has this been benchmarked?

Please describe the benchmarks that you ran to verify your changes.

  • [ ] Benchmark A, on Macbook pro M1, 32GB RAM
  • [ ] Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I did not modify files generated from templates
  • [ ] golangci-lint does not output errors locally
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

drawdrop avatar Aug 12 '24 14:08 drawdrop

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 12 '24 14:08 CLAassistant

Thanks for the contribution. For future reference - we use templates to generate the implementation on different curves. Rerunning go generate ./... would overwrite your changes. I fixed it for now myself (commit 4739395)

ivokub avatar Aug 30 '24 07:08 ivokub