Sarah Groß comments

Results 253 comments of


                                            Sarah Groß

trafficstars

hinting broken on the demo page

This should be fixed now, I encountered it during development for #699. @axkibe please confirm, so we can close this

hinting broken on the demo page

Checked it again and hinting is working now.

Why did we depricate the load function?

The README was updated to state that the method is deprecated with this commit: https://github.com/opentypejs/opentype.js/commit/88c89dcdb2cc8952da9b270f39506afe2b715efa The [deprecated] tag was added to the load() test cases in this commit: https://github.com/opentypejs/opentype.js/commit/a9acb24d90737c9432d77df38ede1c32e270c508 Maybe...

Why did we depricate the load function?

@ILOVEPIE any thoughts in @yne's response?

An unexpected situation occurred when using path. toSVG(), where NaN caused text rendering errors

Thanks for reporting this! We had the discussion before about the rounding method, but it's still the most accurate. I don't know why it would return NaN in those cases,...

Fix keys retrieval in objectsEqual function

Can you please add a test for this that would have caught the issue?

Support searching or filtering by glyph name

So what is the issue or question? Do you want a wrapper function for comfortability?

Support searching or filtering by glyph name

Oh, so you're talking about the glyph inspector demo page. Sure, that shouldn't be too hard to implement

Error parsing some cut font files using 'opentype. parse(...)'

Seems to me as if these files are broken beyond recognition. I doubt that they will be read by any other implementation. Nevertheless I might have a look at them...

Error parsing some cut font files using 'opentype. parse(...)'

[Fontforge](https://github.com/fontforge/fontforge) is able to open those files, if that helps you. We'll have to restructure error handling in opentype.js in the future, to be able to open fonts with errors...