Memory leak on verison 0.24

[pyves007]

Hello, after have tested the version 0.24.0 since the 27th May, it seems that there is steal some memory leaks. I could imagine that we are not alone with this issue. Have a nice day, Py

[sni]

so far, i cannot see any memory issues with the 0.24 on any of the systems i have control of. What are you plotting there? And maybe add some information about which os that is or so?

[k9fr4n]

hello

I confirm that the memory leak is still present I saw it on Windows Server 2016 and 2019 I have a suspicion about "wrapped scripts"...

before:

after:

[sni]

yeah, would be helpful if you could pin down the leak to some specific functionality.

[lgmu]

@pyves007 @FranckSallet we just released 0.25 - it reduces memory usage overall. Could you please give us feedback with that version?

[pyves007]

Thank you, i'll test it.

[lgmu]

I installed it on a windows server 2019 on friday and didn't notice anything regarding memory usage over the weekend. If you still have this issue, please attach your config and let us know which features you use.

[k9fr4n]

Hi

memory leak is still present in version 0.25 I notice that the memory issue seems not to be present when using just the builtin check command. Snclient's memory increases each time an "external script" is used.

Regards

[lgmu]

Hi, thanks for your feedback. I could see a slight increase in memory usage when executing ps1 Scripts. Are you also running ps1 scripts or something else?

[k9fr4n]

yes, mainly powershell scripts

[lgmu]

I've tested this with 1000 executions of a ps1 script, but the memory only increased from 12 to around 16MB. How long do your powershell scripts run? Could you check if a particular one causes this?

[sni]

i cannot reproduce it either. Running ps1 scripts and wrapped ps1 script in a loop but the memory usage is stable.

Could you try to pin this issue (if it still occurs) to a specific check? That would be helpful.

[k9fr4n]

after analysis, I see that the memory leak is located on the default checks I use the check_tasksched via an alias and each time this check is used, the memory increases present on version 0.26

[lgmu]

Thanks, I'll try to reproduce it when I find time for it

[pyves007]

Hello, and thanks to @FranckSallet , i was testing each checks separately also, i have arrived at the same conclusion, i can also said that only the check check_tasksched is producing memory leak.

[lgmu]

Thanks for the input, I can reproduce this with 0.26 - we will fix it

[lgmu]

Issue might be here

[sni]

should be fine now, i replaced the 3rd party module with a powershell script. This makes retrieving scheduled tasks a bit slower, but memory was stable in my tests so far.

[lgmu]

@FranckSallet @pyves007 Is the issue resolved for you guys?

[pyves007]

@lgmu Hello, we are not using anymore the Task Scheduler check so no more memory issue from our side.