farmer icon indicating copy to clipboard operation
farmer copied to clipboard

Authorization Rules - Change to accept list

Open biltongza opened this issue 4 years ago • 1 comments

I think I made a poor choice in making the add_authorization_rule helper on service bus not accept a list of rules. It's inconsistent with the add_queues and add_topics helpers. I'm happy to make changes to it, but it would technically be a breaking change (even though it's brand new and I doubt anyone would really have started using it yet).

Thoughts?

biltongza avatar Jul 05 '21 08:07 biltongza

You can add an overload that takes in a list. Or, just a second method called add_authorization_rules (plural) which takes in the list.

We made the same "mistake" on the arm { } builder which has add_resource and add_resources - don't worry, it's not the end of the world.

isaacabraham avatar Jul 05 '21 20:07 isaacabraham