content
content copied to clipboard
fix: service_disabled/tests: handle socket actication services
Description:
Some systemd services use only socket activation. Like telnet-server under Fedora. Fix their tests.
Rationale:
They have service like: <name>@.service and are only meant to be used
via socket activation via <name>.socket.
Also there is considerable speed difference between slow:
systemctl list-unit-files
and fast:
systemctl list-unit-files
Use fast solution here.
Without this patch rules using these templates fail when tested under default test container when there is socket activation used. There is some package name mismatches too, but more on that in another PR.
Hi @maage. Thanks for your PR.
I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Start a new ephemeral environment with changes proposed in this pull request:
"Gate / Build, Test on OpenSUSE Leap 15" seems to be temporary issue
Code Climate has analyzed commit 7b503c3f and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 42.4% (0.0% change).
View more on Code Climate.
I have rerun the OpenSUSE job, let's see if it passes this time
@maage Can you please rebase this PR on the top of the latest upstream master? They have fixed the testing farm cs9 CI job but they made it required. Also, what do you think about @marcusburghardt 's question?
I didn't receive any answer from @maage for some time. However, I liked the changes he proposed here. If there is no objection until tomorrow, I will merge his PR without my considerations and subsequently open another PR complementing the changes with my suggestions.
/packit retest-failed
This PR was closed in favor of #10026 . The #10026 is a rebase of this PR plus some additional improvements.