content icon indicating copy to clipboard operation
content copied to clipboard

Create slmicro6 product

Open svet-se opened this issue 5 months ago • 2 comments

Description:

  • Create slmicro6 product and general profile

Rationale:

  • Create slmicro6 product and general profile

svet-se avatar Jun 12 '25 14:06 svet-se

Hi @svet-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 12 '25 14:06 openshift-ci[bot]

Code Climate has analyzed commit 7c6661ef and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Jul 02 '25 12:07 qlty-cloud-legacy[bot]

if I could make a suggestion, I think it would be easier to review this PR and specially understand why it affects other products, if it was broken down into smaller PRs. After all the login.defs changes are not really related to the new product but an improvement made while you added this new product. This will also make it easier to understand what commits to cherry-pick for downstream branches different products might have. Just some advice for the future, not that it blocks this PR in anyway right now.

dodys avatar Jul 03 '25 08:07 dodys