content
content copied to clipboard
add variable to network providers and add cilium per default
Description:
This PR adds Cilium to the default regex which is checked to see if the CNI Plugin used provides support for network-policies. This PR also makes this value configurable
Rationale:
Cilium does support Network Policies in different styles: https://docs.cilium.io/en/latest/security/policy/index.html Also making it configurable, allows people to define their own values in the variable without changing sourcecode
Review Hints:
I did not have a Cilium Cluster at Hand. Therefore I checked with default CIS Profile
and a tailored profile which changes the regex and creates a false result in my environment (as expected)
apiVersion: compliance.openshift.io/v1alpha1
kind: TailoredProfile
metadata:
name: test-tailoredprofile-ciliumonly
spec:
description: Example of a tailoredProfile that extends OCP4 FedRAMP Moderate
extends: ocp4-cis
setValues:
- name: ocp4-var-configure-network-policies-regex
rationale: testing Cilium
value: Cilium
title: My little profile
Hi @sluetze. Thanks for your PR.
I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Code Climate has analyzed commit 08847904 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 61.9% (0.0% change).
View more on Code Climate.