content icon indicating copy to clipboard operation
content copied to clipboard

Defined notes and rules for BSI APP.4.4.A18

Open benruland opened this issue 1 year ago • 6 comments
trafficstars

Description: Notes / Rules for BSI APP4.4.A17

Rationale: As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.

This is a follow-up of https://github.com/ComplianceAsCode/content/pull/11659. It was breaken up for better reviewability.

benruland avatar Jul 15 '24 13:07 benruland

Hi @benruland. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 15 '24 13:07 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment) Open in Gitpod

Fedora Testing Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Jul 15 '24 13:07 github-actions[bot]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_configure_network_policies'.
--- xccdf_org.ssgproject.content_rule_configure_network_policies
+++ xccdf_org.ssgproject.content_rule_configure_network_policies
@@ -52,6 +52,9 @@
 APP.4.4.A7
 
 [reference]:
+APP.4.4.A18
+
+[reference]:
 SYS.1.6.A5
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_configure_network_policies_namespaces'.
--- xccdf_org.ssgproject.content_rule_configure_network_policies_namespaces
+++ xccdf_org.ssgproject.content_rule_configure_network_policies_namespaces
@@ -133,6 +133,9 @@
 APP.4.4.A7
 
 [reference]:
+APP.4.4.A18
+
+[reference]:
 SYS.1.6.A5
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_project_config_and_template_network_policy'.
--- xccdf_org.ssgproject.content_rule_project_config_and_template_network_policy
+++ xccdf_org.ssgproject.content_rule_project_config_and_template_network_policy
@@ -38,6 +38,9 @@
 APP.4.4.A7
 
 [reference]:
+APP.4.4.A18
+
+[reference]:
 CNTR-OS-000110
 
 [reference]:

github-actions[bot] avatar Jul 15 '24 14:07 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:12154 This image was built from commit: e5f48b6ed69ce3160dcefe57559732986e2b7ead

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12154

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12154 make deploy-local

github-actions[bot] avatar Jul 15 '24 15:07 github-actions[bot]

/packit test

yuumasato avatar Oct 14 '24 08:10 yuumasato

/lgtm

@benruland I think you'll need to rebase to latest master so that CI runs appropriately

Alright, I just rebased it. Should be fine now

benruland avatar Oct 31 '24 10:10 benruland

Code Climate has analyzed commit b85f0f68 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Oct 31 '24 10:10 qlty-cloud-legacy[bot]