content icon indicating copy to clipboard operation
content copied to clipboard

Fixing rule title for CMP-2485

Open rutvik23 opened this issue 1 year ago • 7 comments

Description:

Rule route_ip_whitelist had an incorrect title and it is pointing to routes_rate_limit.

Rationale:

Fixes CMP-2485

Review Hints:

Both the rules ocp4-route-ip-whitelist and ocp4-routes-rate-limit in compliance operator v1.4.0 have the title Ensure that all Routes has rate limit enabled.

rutvik23 avatar Jun 28 '24 09:06 rutvik23

Hi @rutvik23. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 28 '24 09:06 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Jun 28 '24 09:06 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:12103 This image was built from commit: c3d9958493b75756f5b88e2482d3243ef286ba3c

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12103

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12103 make deploy-local

github-actions[bot] avatar Jun 28 '24 09:06 github-actions[bot]

/packit build

marcusburghardt avatar Jun 28 '24 11:06 marcusburghardt

Code Climate has analyzed commit c3d99584 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Jun 28 '24 12:06 qlty-cloud-legacy[bot]

/packit build

jan-cerny avatar Jun 28 '24 16:06 jan-cerny

/packit build

Mab879 avatar Jun 28 '24 18:06 Mab879

The CI fail is expected because the CentOS 7 has been removed.

jan-cerny avatar Jul 01 '24 06:07 jan-cerny