content icon indicating copy to clipboard operation
content copied to clipboard

Ensure default value in variables

Open marcusburghardt opened this issue 1 year ago • 3 comments

Description:

During some tests it was found two variables without a default value. Ensure a default value based on existing options.

Rationale:

All variables have a default value.

marcusburghardt avatar May 23 '24 14:05 marcusburghardt

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar May 23 '24 14:05 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:12020 This image was built from commit: 15faa0bac811ad0c526337670884ca1ce6afe888

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12020

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12020 make deploy-local

github-actions[bot] avatar May 23 '24 14:05 github-actions[bot]

Code Climate has analyzed commit 15faa0ba and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar May 23 '24 15:05 qlty-cloud-legacy[bot]

@marcusburghardt Can we have some test or build-time check that would prevent this situation? For example I think that when the build system loads a variable from YAML file it could check that it contains the "default" key.

jan-cerny avatar May 27 '24 14:05 jan-cerny

@marcusburghardt Can we have some test or build-time check that would prevent this situation? For example I think that when the build system loads a variable from YAML file it could check that it contains the "default" key.

Hi @marcusburghardt , I plan to introduce a test for this after the https://github.com/ComplianceAsCode/content/pull/12019. It is already in my list here but I would prefer to introduce it later in a different PR, ok?

marcusburghardt avatar May 27 '24 14:05 marcusburghardt