content
content copied to clipboard
Enable dconf profiles in bash remediation of dconf rules on Ubuntu
Description:
- Added enabling of dconf profiles to the remediation of the individual dconf rules instead of relying on rule
enable_dconf_user_profile. - Created new macro
bash_enable_dconf_user_profilefor enabling dconf profiles.
Rationale:
- Several dconf rules checked for the existence of dconf user profiles by extending the oval definition with
enable_dconf_user_profile, but did not create the dconf profiles in their remediations, thus always failing on Ubuntu because the dconf profiles do not exist by default.
Hi @mpurg. Thanks for your PR.
I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Start a new ephemeral environment with changes proposed in this pull request:
rhel8 (from CTF) Environment (using Fedora as testing environment)
:robot: A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12016
This image was built from commit: c2bc84ac3af71999b05164506a31f01e3afcb900
Click here to see how to deploy it
If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12016
Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12016 make deploy-local
/packit build
@marcusburghardt @jan-cerny could you have a look at the test testing-farm:centos-7-x86_64:/static-checks please. It seems to be failing across multiple PRs.
@marcusburghardt @jan-cerny could you have a look at the test
testing-farm:centos-7-x86_64:/static-checksplease. It seems to be failing across multiple PRs.
It should be fixed. I restarted the failed job now.
Code Climate has analyzed commit c2bc84ac and detected 12 issues on this pull request.
Here's the issue category breakdown:
| Category | Count |
|---|---|
| Bug Risk | 12 |
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 59.4% (0.0% change).
View more on Code Climate.
@marcusburghardt @jan-cerny could you have a look at the test
testing-farm:centos-7-x86_64:/static-checksplease. It seems to be failing across multiple PRs.It should be fixed. I restarted the failed job now.
It still seems to be failing.