content icon indicating copy to clipboard operation
content copied to clipboard

Review and reorganize CMakeLists.txt file

Open marcusburghardt opened this issue 1 year ago • 7 comments

Description:

This PR is improving the readability of CMakeLists.txt basically by:

  • Grouping similar entries
  • Organizing the output messages
  • Reviewing comments

Rationale:

Improve readability of CMakeLists.txt file to make easier to work on it.

Review Hints:

Besides the readability of the file and some changes in the output, the test is basically building the products and confirming everything that it still working as expected.

marcusburghardt avatar May 16 '24 10:05 marcusburghardt

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:12000 This image was built from commit: fd7d236508be6527bec53cd300732a92a43328d6

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12000

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12000 make deploy-local

github-actions[bot] avatar May 16 '24 11:05 github-actions[bot]

/packit retest-failed

jan-cerny avatar May 21 '24 11:05 jan-cerny

/packit build

jan-cerny avatar May 21 '24 11:05 jan-cerny

@marcusburghardt Please have a look into the failing test testing-farm:centos-stream-8-x86_64:/static-checks. I have rerun it but it failed again. The error message hints that it might be legitimate:

-- Find Python Modules:
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find PY_jinja2 (missing: PY_JINJA2)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindPythonModule.cmake:40 (find_package_handle_standard_args)
  CMakeLists.txt:150 (find_python_module)

jan-cerny avatar May 22 '24 06:05 jan-cerny

@marcusburghardt Please have a look into the failing test testing-farm:centos-stream-8-x86_64:/static-checks. I have rerun it but it failed again. The error message hints that it might be legitimate:

-- Find Python Modules:
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find PY_jinja2 (missing: PY_JINJA2)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindPythonModule.cmake:40 (find_package_handle_standard_args)
  CMakeLists.txt:150 (find_python_module)

I could not reproduce it locally. I need to investigate it more in a VM similar to CI tests. Moved to Draft for now.

marcusburghardt avatar May 23 '24 11:05 marcusburghardt

I believe the issue is now fixed in the last commit. Just waiting the CI tests to confirm. More details in the commit message.

marcusburghardt avatar May 28 '24 20:05 marcusburghardt

Code Climate has analyzed commit fd7d2365 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar May 28 '24 20:05 qlty-cloud-legacy[bot]