content
content copied to clipboard
Review and reorganize CMakeLists.txt file
Description:
This PR is improving the readability of CMakeLists.txt basically by:
- Grouping similar entries
- Organizing the output messages
- Reviewing comments
Rationale:
Improve readability of CMakeLists.txt file to make easier to work on it.
Review Hints:
Besides the readability of the file and some changes in the output, the test is basically building the products and confirming everything that it still working as expected.
Start a new ephemeral environment with changes proposed in this pull request:
:robot: A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12000
This image was built from commit: fd7d236508be6527bec53cd300732a92a43328d6
Click here to see how to deploy it
If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12000
Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12000 make deploy-local
/packit retest-failed
/packit build
@marcusburghardt Please have a look into the failing test testing-farm:centos-stream-8-x86_64:/static-checks. I have rerun it but it failed again. The error message hints that it might be legitimate:
-- Find Python Modules:
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
Could NOT find PY_jinja2 (missing: PY_JINJA2)
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
cmake/FindPythonModule.cmake:40 (find_package_handle_standard_args)
CMakeLists.txt:150 (find_python_module)
@marcusburghardt Please have a look into the failing test
testing-farm:centos-stream-8-x86_64:/static-checks. I have rerun it but it failed again. The error message hints that it might be legitimate:-- Find Python Modules: CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message): Could NOT find PY_jinja2 (missing: PY_JINJA2) Call Stack (most recent call first): /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE) cmake/FindPythonModule.cmake:40 (find_package_handle_standard_args) CMakeLists.txt:150 (find_python_module)
I could not reproduce it locally. I need to investigate it more in a VM similar to CI tests. Moved to Draft for now.
I believe the issue is now fixed in the last commit. Just waiting the CI tests to confirm. More details in the commit message.
Code Climate has analyzed commit fd7d2365 and detected 0 issues on this pull request.
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 59.4% (0.0% change).
View more on Code Climate.