content icon indicating copy to clipboard operation
content copied to clipboard

[DO NOT MERGE] Testing commit for TF logs workaround

Open mildas opened this issue 1 year ago • 5 comments

Description:

TF test commit

mildas avatar Mar 21 '24 12:03 mildas

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment) Open in Gitpod

Fedora Testing Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Mar 21 '24 12:03 github-actions[bot]

:robot: A k8s content image for this PR is available at: ghcr.io/complianceascode/k8scontent:11739 This image was built from commit: 78da3c0acd0d39c2aded5a106f8cad536d05099c

Click here to see how to deploy it

If you alread have Compliance Operator deployed: utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11739

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11739 make deploy-local

github-actions[bot] avatar Mar 21 '24 13:03 github-actions[bot]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
bash remediation for rule 'xccdf_org.ssgproject.content_rule_configure_usbguard_auditbackend' differs.
--- xccdf_org.ssgproject.content_rule_configure_usbguard_auditbackend
+++ xccdf_org.ssgproject.content_rule_configure_usbguard_auditbackend
@@ -1,20 +1,7 @@
 # Remediation is applicable only in certain platforms
 if ( [ ! -f /.dockerenv ] && [ ! -f /run/.containerenv ] && ! grep -q s390x /proc/sys/kernel/osrelease ) && { rpm --quiet -q usbguard; }; then
 
-if [ -e "/etc/usbguard/usbguard-daemon.conf" ] ; then
-    
-    LC_ALL=C sed -i "/^\s*AuditBackend=/d" "/etc/usbguard/usbguard-daemon.conf"
-else
-    touch "/etc/usbguard/usbguard-daemon.conf"
-fi
-# make sure file has newline at the end
-sed -i -e '$a\' "/etc/usbguard/usbguard-daemon.conf"
-
-cp "/etc/usbguard/usbguard-daemon.conf" "/etc/usbguard/usbguard-daemon.conf.bak"
-# Insert at the end of the file
-printf '%s\n' "AuditBackend=LinuxAudit" >> "/etc/usbguard/usbguard-daemon.conf"
-# Clean up after ourselves.
-rm "/etc/usbguard/usbguard-daemon.conf.bak"
+echo 2
 
 else
     >&2 echo 'Remediation is not applicable, nothing was done'

github-actions[bot] avatar Mar 22 '24 09:03 github-actions[bot]

Code Climate has analyzed commit 78da3c0a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.3% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Mar 26 '24 08:03 qlty-cloud-legacy[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Apr 19 '24 19:04 openshift-merge-robot

Hi @mildas , is this PR still necessary?

marcusburghardt avatar May 28 '24 06:05 marcusburghardt

@marcusburghardt It isn't. Sorry, I forgot this PR is still open

mildas avatar Jun 03 '24 11:06 mildas