Rhys Goodall

Results 69 comments of Rhys Goodall
trafficstars

Here's a slightly more involved setup to play with. I think your issue might have been that your functions are all strongly rank correlated and so the splits locations won't...

https://github.com/scikit-learn/scikit-learn/blob/main/sklearn/tree/_tree.pyx https://github.com/scikit-learn/scikit-learn/blob/678e3999eeaadcaaef523d1d0d2f52a25986d460/sklearn/tree/_splitter.pxd https://github.com/scikit-learn/scikit-learn/blob/678e3999eeaadcaaef523d1d0d2f52a25986d460/sklearn/tree/_criterion.pxd So you need to familiarise yourself with these files. I haven't gone through it in depth myself (no time) but somewhere in there there should be logic...

@jduerholt This is now in a "working" state but it has many rough edges, would appreciate a review and thoughts of how some things may be cleaned up

Not sure why it's trying to test the base class and then giving validation errors ```python strategy_spec = SoboStrategy: {'domain': {'type': 'Domain', 'inputs': {'type': 'Inputs', 'features': [{'type': 'ContinuousInput', 'key... 'failure_counter':...

I want to actually have a chance to check that it works rather than just doesn't fail before moving to have it merged, thought it best to make as draft...

The majority of those changes do not impact how SEBO might be implemented here because the homotopy stuff is in botorch and then it's just using qnehvi so would require...

Looking forward to it, this PR https://github.com/pytorch/botorch/pull/2588 to botorch should have exposed everything needed to allow all the constraints allowed by botorch.

This isn't pressing for me but just forward looking as I try make sure Ax will work for most the problems I imagine the team might ask me for solutions...

The string parameter could still be useful for optimisation based approaches as there are generation strategies being pushed for text-serialisable problems such as molecule properties (smilies) and protein design (amino...

> Is the idea here that we could construct a 1D search space where the single dimension can take on any SMILES string, without necessarily capturing any information about order...