Frank Elsinga

Results 1015 comments of Frank Elsinga
trafficstars

Okay.. So I got performance up there again. Was a good call to do benchmarks 😅 I think there are severe performance issues with my ssh-terminal and rendering special characters...

Okay.. so apparently this gets logged.. ![image](https://github.com/user-attachments/assets/0e0e71b8-521d-4868-9988-9055129e4126) https://docs.rs/tokio-postgres/latest/src/tokio_postgres/connection.rs.html#338 This is because we ask postgres do do so.. https://github.com/maplibre/martin/blob/31fc566d586a773d43a8ebb54bd3a0af89cf3519/tests/fixtures/functions/function_zxy_query.sql#L7

So apparently some of our dependencys log via tracing (switch on the trace level to see it.. that is a lot). There is the expected change from not having so...

No clue where CI and my local device is different. Will investigate further in the last part of the week. ![image](https://github.com/user-attachments/assets/6808b9fb-9b00-44f5-9683-83f2671a6794) ![image](https://github.com/user-attachments/assets/15de9903-847d-4bf1-82c5-47ae45bb55ba)

@nyurik how would you want me to split this up? I don't think this is currently a reviewable amount.. How about `martin-observability-utils` and the rest? (or strictly on the crate...

> * the monitoring utility is clearly a separate PR I think there is some misunderstanding. I am talking about the code pulled from the three crates to configure `tracing`....

Above I was talking about making this PR reviewable by splitting it up into smaller PRs. Currently this is a +900 -300 lines chonker of a PR (even though a...

there were some merge-issues and I think it is simplest to just redo the work I have done in this PR, if we get https://github.com/maplibre/martin/pull/1747 merged.

Not a lot of detail here. - Can you `curl` the requested URL? - What happens when you visit the URL in the browser?

> There is no error messages or logs. > *** If I need to share, please let me know where to find the logs. Depends on your runtime. For docker...