Frank Elsinga

Reworked the PR to adress my concerns: https://github.com/louislam/uptime-kuma/pull/4817

Thanks a lot for the contribution. Next step is a review of https://github.com/louislam/uptime-kuma/pull/4817 and if found good, this is merged in to the next release (dependent on reviewer availability) ^^

There may be other merge conflicts that come up. v2.0 does support mariadb next to sqlite, but said db still needs to be integrated here as well

I think this should not cause a merge-conflict if merged directly after https://github.com/louislam/uptime-kuma/pull/4436 Am I missing some context? What might indeed be problematic is that users can't supply translations for...

> For simplicity, I would suggest this pr should be merged into the master branch directly and also be merged after #4436. I have rebase the PR in https://github.com/louislam/uptime-kuma/pull/4814 (different...

Merging as we had to merge https://github.com/louislam/uptime-kuma/pull/4394 due to https://github.com/louislam/uptime-kuma/issues/4788

Thanks for the better design! 🎉 > [!NOTE] > This PR is part of the [`v2.0` merge window](https://github.com/louislam/uptime-kuma/milestone/24) => see #4500 for the bugs that need to be addressed before...

That would be my idea. An alternative approach would be registering+ de-registering an event listener in the `mounted`/.. lifecycle hooks.

The next time around please have a discussion how to implement a new feature beforehand (see our contribution guide). This paragraph was added to safe us all time ^^ To...

> Personally, if I wanted to show one monitor's description on a status page, I would want to show it for all the monitors. This is another point where https://github.com/louislam/uptime-kuma/issues/4456...