Colt Allen
Colt Allen
This issue has been fixed in the [pymc-marketing](https://github.com/pymc-labs/pymc-marketing) successor project.
> @ColtAllen this looks good! I wanna merge this one and iterate (I can help with that). I have just two requests :D : > > * Remove commented code...
plot_prior_predictive() gives error "RuntimeError: The model hasn't been fit yet, call .fit() first"
From https://github.com/pymc-labs/pymc-marketing/blob/916dce42b39c67ee3a04188ba492ac53f5e6504d/pymc_marketing/mmm/base.py#L256C72-L256C72: ```python def plot_prior_predictive( self, samples: int = 1_000, **plt_kwargs: Any ) -> plt.Figure: prior_predictive_data: az.InferenceData = self.prior_predictive ``` `self.prior_predictive is None` because `pm.sample_prior_predictive()` hasn't been called yet. This...
Hey @gdberrio, You did nothing wrong - in fact, thanks for sharing the error trace, as it made this issue really easy to diagnose: There were some significant internal changes...
Just opened a PR because I decided broken functionality like this should be given top priority.
While working on [btyd](https://github.com/ColtAllen/btyd), I got a request to add a chart to the documentation highlighting the differences between the various models. On the matter of model discovery, I've been...
> I like the name of CLV as the sub-package. The `L` stands for the lifetime and the `V` for value, no? After seeing that fake Bible verse about CLV...
> This would be great as a documentation piece! Have you started working on this / do you have any ideas? I'm still learning the nuances of these models (and...
Are nested priors the primary motivation for this? That was my understanding when I commented on https://github.com/pymc-labs/pymc-marketing/issues/708. If so, I think this should be relocated to the base `ModelBuilder` class...