AdminLTE icon indicating copy to clipboard operation
AdminLTE copied to clipboard

Added FullScreen functionality

Open burdittw opened this issue 3 years ago • 1 comments

Added the necessary JavaScript to allow for full screen mode to be used. This code uses the MDN Fullscreen API and also takes the F11 browser mode into account to change the icon to extend and compress depending if in full screen mode or not. I have tested this code on Edge, Firefox, and Brave with no issues.

burdittw avatar Jun 16 '22 08:06 burdittw

@danny007in

New code has been commited that allows for anything to be used as the icons as long as the fullscreen/fullscreen-icon/lte-show css classes are used. I tested with font-awesome and the heroicon svg's with no issues. Hope this works this time.

burdittw avatar Jun 27 '22 06:06 burdittw

@danny007in and @REJack

Items resolved in this updated PR:

  1. I have merged the new v4-dev branch into my fullscreen PR and the conflicts have been resolved.
  2. Updated icons to font-awesome 6.2.1.
  3. Seperated the fullscreen scss into its own file as requested by @REJack.

Ready for approval!

burdittw avatar Feb 06 '23 04:02 burdittw

@danny007in

I have edited this code to match up with all your changes. The checks that are making it fail are in the base code and not my code. The lint errors are in files I have not changed so nothing I can really do about it, as I am not sure what your plan is with those items.

  • I merged and fixed the conflicts with all your changes and moving dev-4 to master/main.
  • I fixed lint issues with Fullscreen.ts file
  • I updated the code that used to be domReady to use the new onDOMContentLoaded
  • I changed out the icon links that were using font-awesome to use bootstrap icons to stay in line with the project.

Let me know if you need me to change anything on this PR. It should be ready to go and keeps with the previous approval of the fullscreen functionality.

burdittw avatar Sep 01 '23 07:09 burdittw

Make PR commit readable https://www.youtube.com/watch?v=gXCkYkLQ3To

danny007in avatar Sep 12 '23 09:09 danny007in

@burdittw thanks for your PR, we have upgraded your PR here https://github.com/ColorlibHQ/AdminLTE/blob/master/src/ts/fullscreen.ts if any bug or improvement is there please check

danny007in avatar Sep 14 '23 12:09 danny007in