cvr-sdk-unity icon indicating copy to clipboard operation
cvr-sdk-unity copied to clipboard

script to automate analytics additions

Open Div-c3d opened this issue 2 years ago • 6 comments

Description

Tool to automatically scan project for preexisting analytics events and insert corresponding Cognitive3d custom events

Height Task ID (If applicable):

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

Div-c3d avatar Jul 22 '23 01:07 Div-c3d

Hi Div - Looks like you have a few Codacy recommendations / requirements still to update. Let Calder and Atif know when you've updated your code so they can review before merging your branch. Thanks!

matt-manuel avatar Aug 01 '23 17:08 matt-manuel

Hi Div - Looks like you have a few Codacy recommendations / requirements still to update. Let Calder and Atif know when you've updated your code so they can review before merging your branch. Thanks!

I think they're good to go now? Only warnings remain that seem benign

Div-c3d avatar Aug 01 '23 18:08 Div-c3d

Can you add the Cognitive3D namespace?

calderarchinuk avatar Aug 01 '23 18:08 calderarchinuk

Can you add the Cognitive3D namespace?

@Div-c3d see above

Labec avatar Aug 25 '23 03:08 Labec

@AtifMahmud Any harm in approving and closing this PR? Or should we nuke it. It was Div's hackathon project.

matt-manuel avatar Dec 20 '23 23:12 matt-manuel

@AtifMahmud Any harm in approving and closing this PR? Or should we nuke it. It was Div's hackathon project.

@matt-manuel a few more changes need to be made before we can merge. https://c3d.height.app/T-3700

AtifMahmud avatar Dec 21 '23 20:12 AtifMahmud