cogcomp-nlp icon indicating copy to clipboard operation
cogcomp-nlp copied to clipboard

no helpful error message if model file not found

Open mssammon opened this issue 7 years ago • 2 comments

no indication that minio looked anywhere -- am I wrong? just an error about path it tried that did not work. Looks like there is now a disconnect between the name specified in the default config files (for conll and ontonotes) and the actual string used to build the path to check for models. "Main" class does the checks, but other older entrypoints don't. Update the Main class to allow default args of input and output folder + config file. Consider scrapping the main() method in NerTagger, after adding any missing functionality to Main.

mssammon avatar Jul 20 '18 18:07 mssammon

@cowchipkid this was in the context of using NER; I'm pretty sure your recent changes are relevant/might have solved this issue. Any thoughts?

mssammon avatar Sep 06 '18 14:09 mssammon

The way this works now is that it will first check the file system. If not found, it checks the classpath. And if it is not there, it will check the view name. If the view name contains NER_CONLL it will load the default CoNLL model, it if contains NER_ONTONOTES, it will load the default Ontonotes model. Finally, if the view name does not match either of these names, it will throw an illegal argument exception. Not of my most recent changes impacted this, but I did change this I think 2 revs ago.

cowchipkid avatar Sep 06 '18 14:09 cowchipkid