cogcomp-nlp icon indicating copy to clipboard operation
cogcomp-nlp copied to clipboard

AnnotationReader default constructor is public

Open mssammon opened this issue 7 years ago • 0 comments

This constructor is not intended for use -- the version with ResourceManager must be used or the initialize step won't work. Error message is logged but no exception thrown: https://github.com/CogComp/cogcomp-nlp/blob/master/corpusreaders/src/main/java/edu/illinois/cs/cogcomp/nlp/corpusreaders/AnnotationReader.java#L35

EITHER: refactor AnnotationReader to obviate intialize() call (hard) OR make constructor private OR throw an exception/system exit.

mssammon avatar May 03 '18 18:05 mssammon