cogcomp-nlp icon indicating copy to clipboard operation
cogcomp-nlp copied to clipboard

Extending FeatureExtractor

Open danyaljj opened this issue 8 years ago • 1 comments

I am thinking about extending FeatureExtractor so that it can be applied in other formats in addition to Constituents. In particular I want to have feaure extractors for

  • Relation
  • View
  • ?

To do that I will rename the existing class to ConstituentFeatureExtractor and will have it extend a parent class FeatureExtractor which will be extrended by other types of feature extractors.

What do you think @mssammon ?

danyaljj avatar Nov 09 '17 21:11 danyaljj

Or change the definition of the feature extraction to support a type:

public interface FeatureExtractor<T> {
    Set<Feature> getFeatures(T c) throws EdisonException;
    String getName();
}

danyaljj avatar Nov 10 '17 01:11 danyaljj