cogcomp-nlp
cogcomp-nlp copied to clipboard
Extending FeatureExtractor
I am thinking about extending FeatureExtractor so that it can be applied in other formats in addition to Constituents. In particular I want to have feaure extractors for
- Relation
- View
- ?
To do that I will rename the existing class to ConstituentFeatureExtractor and will have it extend a parent class FeatureExtractor which will be extrended by other types of feature extractors.
What do you think @mssammon ?
Or change the definition of the feature extraction to support a type:
public interface FeatureExtractor<T> {
Set<Feature> getFeatures(T c) throws EdisonException;
String getName();
}