cogcomp-nlp
cogcomp-nlp copied to clipboard
getview vs addview
@mssammon In Annotator, getView and addView functions seem to be doing the same thing (one lazy and one not-lazy). Is that really the difference, or anything else I'm missing?
you are correct. 'addView()' is intended to wrap the actual logic for the annotator behavior, while 'getView()' is the public interface. I wanted 'addView()' to be abstract in the base class.
I think the naming is a little confusing. I wonder if we can merge them together as one name? I don't think it is clear what is the difference between these two functions without looking inside the code.