Submissions for Assignment1

[KenanBek]

trafficstars

[mirpulatov]

https://github.com/mirpulatov/pyCalculator

[Jlopezjlx]

https://github.com/Jlopezjlx/calc_basic_py

[Prrrince]

https://github.com/Prrrince/PyCalc

[ghost]

https://github.com/HelSirius/python-mentorship/tree/master/src/calculator/Menthorship2.0

[KenanBek]

@HelSirius that's great! We all probably need to move to PR instead of separate repositories. For this, I need to prepare a proper repo structure. Will to it today and publish tomorrow.

@mirpulatov @Jlopezjlx @Prrrince @HelSirius today will do all code reviews and merge your code into the main repository.

[ghost]

NIce! Thank you

[Jlopezjlx]

Thank you!

[KenanBek]

To all members:

• Please check Python Style Guide (https://www.python.org/dev/peps/pep-0008/)
• Always add tests

Comments for @HelSirius:

• use naming conventions
• use one variable for operations
• add unit tests

Comments for @Prrrince:

• I liked usage of Arrays, Try/Except
• I would add one more Except for generic exception
• add unit tests

Comments for @Jlopezjlx:

• use endless loop (while)
• use Try/Except
• add unit tests

Comments for @mirpulatov:

• use Try/Except
• add unit tests
• for class implementation add init.py to the folder

[KenanBek]

Video with the detailed comments will be published today (5 April, Friday)

[ghost]

Thank you for the comments .... I will fix it

[KenanBek]

Thank you for the comments .... I will fix it

@HelSirius please, fix it based on the latest version of the repository because it is updated and now contains your code. Before sending new PR I recommend you to wait for the Video with my comments. It will be published within a few hours.

[ghost]

@KenanBek sure! will wait for the video

[Jlopezjlx]

HI, this is my PR request: https://github.com/CoderVlogger/python-mentorship/pull/4

[mirpulatov]

Hi. I did the fixes https://github.com/CoderVlogger/python-mentorship/pull/5

[KenanBek]

@mirpulatov your PR is merged. @Jlopezjlx added 2 comments for your PR, please check them.