java-ddd-example icon indicating copy to clipboard operation
java-ddd-example copied to clipboard

Published 20 hours ago • verified publisher icon CodelyTV

Fix test password_does_not_match and improve CI workflow

Open borjapazr opened this issue 4 years ago • 2 comments

Sometimes the randomly generated password for the AuthenticateUserCommand matches the randomly generated AuthUser password. Because of this, the throw_an_exception_when_the_password_does_not_match test fails.

This issue has been fixed and the GH Actions CI workflow has also been updated.

borjapazr avatar Nov 16 '21 23:11 borjapazr

Hi @borjapazr!

Sorry for not reviewing this PR on time when you firstly submitted it. Our fault 🙏

However, I have received the close PR notification now, and the modifications seems totally appropriate. Would you mind if I reopen the PR and merge it?

Thanks a lot for submitting it!

JavierCane avatar Oct 31 '22 10:10 JavierCane

Hi @JavierCane.

You don't even have to apologize 😊. I was reviewing the old PRs I had opened and closed because I thought maybe you had already thought of another way to solve it.

I'm happy to reopen it.

Thanks for the feedback and for your day to day work 🚀

CodelyTV rocks! 🤘

borjapazr avatar Oct 31 '22 10:10 borjapazr