Change position property from top to right

[molivier1988]

trafficstars

Description

Docs / css / concepts / position / terms / right.md

Assigned to add additional media to accurately represent code blocks. Noticed that code examples used top instead of `right.

Issue Solved

Issue #4074 changed position property from top to right

Type of Change

• Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

• [x] All writings are my own.
• [x] My entry follows the Codecademy Docs style guide.
• [x] My changes generate no new warnings.
• [x] I have performed a self-review of my own writing and code.
• [x] I have checked my entry and corrected any misspellings.
• [x] I have made corresponding changes to the documentation if needed.
• [x] I have confirmed my changes are not being pushed from my forked main branch.
• [ x I have confirmed that I'm pushing from a new branch named after the changes I'm making.
• [x] I have linked any issues that are relevant to this PR in the Issues Solved section.

[CLAassistant]

All committers have signed the CLA.

[mamtawardhani]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @molivier1988, could you please sign the CLA? Also, this entry requires an output image, could you please add that as well? You can store the image under the "media" folder in docs. Thank you! 😃

[mamtawardhani]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @molivier1988, could you please sign the CLA? Also, this entry requires an output image, could you please add that as well? You can store the image under the "media" folder in docs. Thank you! 😃

Hey @molivier1988 could you please make the required change at your earliest convenience?

[mamtawardhani]

Hey @molivier1988 if you don't make the required changes within two days, unfortunately I'll have to close this PR and unassign you.

[molivier1988]

Hi Mamta,

I’m still very new to all this, when you say make changes are you referring to the changes I recommended in my pull request?

KR

Mark

On 12 Jul 2024, at 13:09, Mamta Wardhani @.***> wrote:

Hey @molivier1988 https://github.com/molivier1988 if you don't make the required changes within two days, unfortunately I'll have to close this PR and unassign you.

— Reply to this email directly, view it on GitHub https://github.com/Codecademy/docs/pull/4848#issuecomment-2225447980, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5P2FJRVFRGQM2YTLHTJHDZL7BRFAVCNFSM6AAAAABKAJ6QH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRVGQ2DOOJYGA. You are receiving this because you were mentioned.

[mamtawardhani]

Hi Mamta, I’m still very new to all this, when you say make changes are you referring to the changes I recommended in my pull request? KR Mark … On 12 Jul 2024, at 13:09, Mamta Wardhani @.***> wrote: Hey @molivier1988 https://github.com/molivier1988 if you don't make the required changes within two days, unfortunately I'll have to close this PR and unassign you. — Reply to this email directly, view it on GitHub <#4848 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5P2FJRVFRGQM2YTLHTJHDZL7BRFAVCNFSM6AAAAABKAJ6QH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRVGQ2DOOJYGA. You are receiving this because you were mentioned.

Hello @molivier1988, yes, so basically this PR needs an output image as well as mentioned in the issue. So all you need to do is, include an image (while you are still on this same branch css-position-right and commit the changes and push them. Hope this helps 😁

[mamtawardhani]

Hey @molivier1988, could you please try to push the changes in the next two days since it has been 3 weeks to this PR.

[molivier1988]

Will work on it tonight

On 17 Jul 2024, at 09:18, Mamta Wardhani @.***> wrote:

Hey @molivier1988 https://github.com/molivier1988, could you please try to push the changes in the next two days since it has been 3 weeks to this PR.

— Reply to this email directly, view it on GitHub https://github.com/Codecademy/docs/pull/4848#issuecomment-2232713418, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5P2FILLFLEFDXJM5LLUQDZMYSDXAVCNFSM6AAAAABKAJ6QH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSG4YTGNBRHA. You are receiving this because you were mentioned.

[mamtawardhani]

Will work on it tonight … On 17 Jul 2024, at 09:18, Mamta Wardhani @.***> wrote: Hey @molivier1988 https://github.com/molivier1988, could you please try to push the changes in the next two days since it has been 3 weeks to this PR. — Reply to this email directly, view it on GitHub <#4848 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5P2FILLFLEFDXJM5LLUQDZMYSDXAVCNFSM6AAAAABKAJ6QH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSG4YTGNBRHA. You are receiving this because you were mentioned.

Sure thing! Let me know once you are done 😃

[molivier1988]

PR submitted, sorry for delaySent from my iPhoneOn 18 Jul 2024, at 09:58, Mamta Wardhani @.***> wrote:

Will work on it tonight … On 17 Jul 2024, at 09:18, Mamta Wardhani @.***> wrote: Hey @molivier1988 https://github.com/molivier1988, could you please try to push the changes in the next two days since it has been 3 weeks to this PR. — Reply to this email directly, view it on GitHub <#4848 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5P2FILLFLEFDXJM5LLUQDZMYSDXAVCNFSM6AAAAABKAJ6QH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSG4YTGNBRHA. You are receiving this because you were mentioned.

Sure thing! Let me know once you are done 😃

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

[mamtawardhani]

PR submitted, sorry for delaySent from my iPhoneOn 18 Jul 2024, at 09:58, Mamta Wardhani @.> wrote: Will work on it tonight … On 17 Jul 2024, at 09:18, Mamta Wardhani @.> wrote: Hey @molivier1988 https://github.com/molivier1988, could you please try to push the changes in the next two days since it has been 3 weeks to this PR. — Reply to this email directly, view it on GitHub <#4848 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV5P2FILLFLEFDXJM5LLUQDZMYSDXAVCNFSM6AAAAABKAJ6QH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZSG4YTGNBRHA. You are receiving this because you were mentioned. Sure thing! Let me know once you are done 😃 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

No worries @molivier1988. Closing this PR since a new PR has been raised.

[molivier1988]

Is there anything else I need to do?