django-relativedelta icon indicating copy to clipboard operation
django-relativedelta copied to clipboard

increase supported django version to < 5

Open tiholic opened this issue 3 years ago • 4 comments

Increase django supported version from < 4 to < 5

Note: prefer squash and merge on this PR please :)

tiholic avatar Mar 22 '22 18:03 tiholic

@sjamaan @ashishnitinpatil @emanuelmd @mkay849 - will this be merged soon? It is now a blocker for our project and would prefer not to have to fork your project just for this.

chris-umed avatar Aug 10 '22 10:08 chris-umed

This should ideally be tested for django version 4. The project has a tox.ini which should be updated along with the requirements change and well, tested. I do not maintain the library so have no permissions to merge or release.

ashishnitinpatil avatar Aug 10 '22 14:08 ashishnitinpatil

This should ideally be tested for django version 4. The project has a tox.ini which should be updated along with the requirements change and well, tested. I do not maintain the library so have no permissions to merge or release.

Unfortunately, I don't work with Django anymore at the moment and I won't have the time to maintain this library. Perhaps @abzainuddin can have a look - the change LGTM at least, although the gettext suppression seems to have disappeared? I'd suggest at least changing the commit message before merging.

sjamaan avatar Aug 11 '22 06:08 sjamaan

Given Django 2 is no longer officially supported and it creates complications to support v2 and v4, Django 2 should no longer be supported and users stil on Django 2 can download the current released version. A PR will be raised shortly that implements github actions to run the tox tests and supports Django 4 by @martin-marty

uhurusurfa avatar Aug 11 '22 09:08 uhurusurfa