dailycodebase icon indicating copy to clipboard operation
dailycodebase copied to clipboard

Add a PR template

Open MadhavBahl opened this issue 5 years ago • 12 comments

Add the following check list in the PR template:

  • [ ] Created a folder with the name of language you code inside directory for the day you are making the contribution to
  • [ ] Added your Codes
  • [ ] Tested your codes
  • [ ] Added credits (author and date) at the top of the code
  • [ ] Updated README.md of the day you are contributing to
  • [ ] Added yourself as a contributor using all-conributors-cli

MadhavBahl avatar Oct 05 '20 07:10 MadhavBahl

Hi @MadhavBahlMD. I'd be glad to work on this. Can you assign me to the issue?

SvA1 avatar Oct 05 '20 08:10 SvA1

Hey @MadhavBahlMD can I work on this?

thelavenderhue avatar Oct 05 '20 10:10 thelavenderhue

Hi @MadhavBahlMD this looks good. Could you assign me the issue?

yashasvimatta avatar Oct 05 '20 10:10 yashasvimatta

Please assign @MadhavBahlMD I will try my best

Red-0111 avatar Oct 05 '20 13:10 Red-0111

Hey guys,

Thanks a lot for your enthusiasm to contribute,

You all can feel free to take this issue and raise a PR,

Although I would recommend @SvA1 to take this up since he commented first,

but you all can feel free to discuss ideas here, and also take up lead on more ideas for this repository 🥳

MadhavBahl avatar Oct 05 '20 16:10 MadhavBahl

Thanks!

SvA1 avatar Oct 05 '20 17:10 SvA1

Hi @MadhavBahlMD i have created a pull request for fixing the issue , could you review it?

yashasvimatta avatar Oct 07 '20 15:10 yashasvimatta

I've made one PR for this issue, could you review it ? @MadhavBahlMD

diogenesdauster avatar Oct 09 '20 14:10 diogenesdauster

Hi @yashasvimatta and @diogenesdauster Thanks a lot for your contributions 🥳 I will have a look at both your PRs on weekend

MadhavBahl avatar Oct 14 '20 07:10 MadhavBahl

@MadhavBahlMD hi i am new to this github. i have made changes to the readme and the uploaded the code in the required directory but i am still having troubling to add my name into the contributors list. i did looked into the contributing guidelines but i am still unable to understand could you please guide me

rajpratyush avatar Oct 14 '20 07:10 rajpratyush

Hi @MadhavBahl ! can I work on this?

elizabethqiu avatar Oct 25 '20 14:10 elizabethqiu

Hi @MadhavBahl , I would like to work on this.

NormalVad avatar Oct 25 '20 15:10 NormalVad