prevention-point icon indicating copy to clipboard operation
prevention-point copied to clipboard

add prettier to configs

Open mariekers opened this issue 5 years ago • 3 comments

  • [ ] husky should run prettier --fix or equivalent before commit attempt, so easy fixes can be handled automatically instead of manually
  • [ ] update style rules to require single quote in js syntax and doublequote in jsx

mariekers avatar May 04 '20 18:05 mariekers

This might want to be paired with just a mass reformatting of the code base. Have one giant commit that formats all the files first does two things.

  1. it makes it so that the commit that did the reformatting can be excluded from diffs/blame or at least its a known point in time when the work was done
  2. It makes future work easier because small changes aren't lumped in with large formatting changes making PR's a bit of a pain trying to decide whats an actual change vs what was a formatting change.

ThrowsException avatar May 12 '20 12:05 ThrowsException

black formatter works for me for the back end. I doubt anyone will object.

the biggest thing that sticks out to me for the front end code is the quotation marks, lets try and identify any other ones.

PS husky should also run eslint fix. my bad.

MikeyManoguerra avatar May 12 '20 13:05 MikeyManoguerra

@MikeyManoguerra @ThrowsException would you want a different milestone for reformatting?

mariekers avatar Jul 11 '20 17:07 mariekers