CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

🐞 Missing Terminal font

Open N3v1 opened this issue 2 years ago β€’ 11 comments

Description

Hi guys, @austincondiff, Based on my observations, it appears that the font is not functioning properly for OhMyZsh and Powerlevel 10k themes. To address this issue, we need to carefully review the user's primary Terminal configurations and make use of them accordingly. For that, we require a function capable of searching for Terminal Configurations. One possible solution to this problem is to install the 'MesloLGS NF' font or create the aforementioned function.

Best regards NH

To Reproduce

  1. Use iTerm2 and set Powerlevel 10k as color theme
  2. Open CodeEdit (newest Version)
  3. see issue in the terminal tab

Expected Behavior

The icons should be visible instead of boxes with question marks

Version Information

CodeEdit: 0.0.3-alpha (36) macOS: 14 RC2 Xcode: 15 RC

Additional Context

No response

Screenshots

Bildschirmfoto 2023-09-22 um 21 14 34

N3v1 avatar Sep 22 '23 19:09 N3v1

see my discord message

N3v1 avatar Sep 22 '23 19:09 N3v1

Can you provide more clarifications on this? There is other fonts supported for our integrated terminal. What you want is more like import configuration from other editors?

Qubik65536 avatar Oct 06 '23 22:10 Qubik65536

Sorry @Cubik65536 Forgot this issue. Iβ€˜m answering it in a few hours because Iβ€˜m now going to sleep (itβ€˜s almost 1 am here in Italy)

N3v1 avatar Oct 06 '23 22:10 N3v1

Sorry @Cubik65536 Forgot this issue. Iβ€˜m answering it in a few hours because Iβ€˜m now going to sleep (itβ€˜s almost 1 am here in Italy)

@N3v1 I'm still waiting for your response ;)

Qubik65536 avatar Oct 11 '23 20:10 Qubik65536

I thought about a function that looks for the font used by the main terminal and uses it. So the user has to allow that CE can see the .zshrc file (if possible). Or sth like that. @Cubik65536 here. I'm sorry, I forgot to reply to this issue. I just got back home yesterday

N3v1 avatar Oct 11 '23 21:10 N3v1

I thought about a function that looks for the font used by the main terminal and uses it. So the user has to allow that CE can see the .zshrc file (if possible). Or sth like that. @Cubik65536 here. I'm sorry, I forgot to reply to this issue. I just got back home yesterday

The .zshrc file doesn't contain any font information.

So you want CodeEdit to get what font are used by terminal apps like Terminal.app or iTerm.app and set that as default one?

Personally I don't think that this is necessary as neither vscode nor other similar editors does that. The user might want to set different font for different apps (especially between terminal emulator app and an text editor). And to solve the issue that terminal of CE shows [?], user just have to set the p10k compatible font with CE settings.

Qubik65536 avatar Oct 11 '23 21:10 Qubik65536

Is this a CodeEdit or SwiftTerm issue? I can imagine that SwiftTerm just doesn't know what to do, so it renders there questionmarks. Keep in mind that it is a emulator, not an embedded terminal.

matthijseikelenboom avatar Oct 12 '23 09:10 matthijseikelenboom

Yeah I think so because I also changed the Terminal font in CE in the settings but nothing happens Bildschirmfoto 2023-10-12 um 11 40 55 Bildschirmfoto 2023-10-12 um 11 40 58 Bildschirmfoto 2023-10-12 um 11 42 21

N3v1 avatar Oct 12 '23 09:10 N3v1

@N3v1 Oh okay I entirely misunderstood the issue. In fact what you want to talk is CodeEdit terminal not applying a font configured in settings. I’ll investigate a bit.

Qubik65536 avatar Oct 12 '23 11:10 Qubik65536

Follow Discord discussion https://discord.com/channels/951544472238444645/952640818068463667/1162241131178885160. I cannot reproduce this issue.

Qubik65536 avatar Oct 13 '23 04:10 Qubik65536

There is definitely some strange things happening...

https://github.com/CodeEditApp/CodeEdit/assets/806104/1fb4b7fc-711c-4100-9d0b-d2e456e145b8

In summary...

  1. I simply toggle off Settings β†’ Terminal β†’ Use text editor font
    • Characters are very spaced out even though the editor and the terminal still use the same font settings.
  2. In Settings β†’ Terminal β†’ Font, I choose a Powerlevel 10k font, in this case "MesloLGS NF"
    • Font remains the same (System Font) despite my selection, however characters are now properly spaced
  3. I set Font to something that doesn't support Powerlevel 10k, in this case "Input Mono"
    • Powerlevel 10k glyphs are applied while other characters are of the font I chose
  4. I set Font back to my Powerlevel 10k font, "MesloLGS NF"
    • Everything looks as it should

austincondiff avatar Oct 18 '23 14:10 austincondiff