foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Remove obsolete command line options

Open kseo opened this issue 5 years ago • 5 comments

Check if the following options are still necessary:

~work-queue-size~ ~no-reseal-timer~ ~reseal-max-period~

  • reseal-min-period
  • reseal-on-txs
  • force-sealing

kseo avatar Feb 07 '20 12:02 kseo

@majecty I checked all of these commands some of them are still in the code. Do I need to remove any usage of them? For force-sealing, it uses in some of the tests. Can you explain what is the purpose of force-sealing?

MSNTCS avatar Sep 08 '20 10:09 MSNTCS

@MSNTCS AFAIK, force-sealing is used to create blocks in solo consensus even though there are no transactions. I think we can remove it if we remove solo consensus. I know that some code written in the mold branch does not consider the solo consensus. So we may remove it when the mold code is merged in the master branch.

majecty avatar Sep 09 '20 09:09 majecty

@MSNTCS Please check them if they are used in a meaningful way. If understanding them is difficult, please let this issue.

majecty avatar Sep 09 '20 09:09 majecty

@majecty some of them can be easily removed but some of them need to be carefully removed. For the second one, I also need some knowledge which will take time to fully understand it.

MSNTCS avatar Sep 10 '20 04:09 MSNTCS

This PR will remove some of the obsolete commands while the last two commands need more time to go over all their usage.

MSNTCS avatar Sep 15 '20 09:09 MSNTCS