Magic-Spoiler

Magic-Spoiler copied to clipboard

On line 531 of `__main.py__`, `excluded_set_types` currently excludes sets tagged as `draft_innovation` on Scryfall. Sets in that category include Assassin's Creed, the various Modern Horizon, and Commander Legends. The type...

LumaddT

added check for duplicate cards

1

Fixes [#287](https://github.com/Cockatrice/Magic-Spoiler/issues/287) Tested on the new spoilers; master has multiple copies of the new cards, this resolves that. Also tested on KHM w/ double-sided cards. Master: ``` Alrund, God of...

rglerum

Don't fail script for missing card type

5

Recent runs started to fail and spoilers are not updated since 2 days:

tooomm

tooomm

CI: Add code scans & style checks

6

Run `pylint` and utilize our [.pylintrc](https://github.com/Cockatrice/Magic-Spoiler/blob/master/.pylintrc) file. Run `isort` to check sorting of imports. Run `mypy` and utilize our [mypy.ini](https://github.com/Cockatrice/Magic-Spoiler/blob/master/mypy.ini) file. #214

tooomm

There used to be a verification of the XML files in the main script: https://github.com/Cockatrice/Magic-Spoiler/pull/105 This got once silently removed without replacement it looks like. It should be done in...

tooomm

Our script creates a new card with identical values, expect a different picture URL. See example in [current deployment](https://github.com/Cockatrice/Magic-Spoiler/blob/d881ba2564363a41e7544a500c8c9c972fd947f2/spoiler.xml#L6387-L6425): ``` Tezzeret, Betrayer of Flesh The first activated ability of an...

tooomm

CI: Run tests

2

Linking #159 [`tox -e py`](https://github.com/Cockatrice/Magic-Spoiler/runs/1488700413#step:5:1) log [`python -m tox`](https://github.com/Cockatrice/Magic-Spoiler/runs/1488677358#step:5:1) log

tooomm

To somehow track the progress of ongoing spoilers there could be a `101/269 cards` hint somewhere in the xml file. The currently available number of cards is there in the...

tooomm

documentation updates

5

- [ ] [CONTRIBUTING.md](https://github.com/Cockatrice/Magic-Spoiler/blob/master/.github/CONTRIBUTING.md) (e.g. code style conventions: https://github.com/Cockatrice/Magic-Spoiler/pull/98#issuecomment-313163870) - [ ] [README.md](https://github.com/Cockatrice/Magic-Spoiler/blob/master/README.md): part for developer and part for user (e.g. quick links to user editable files) - [ ]...

tooomm