NachoSpigot
NachoSpigot copied to clipboard
CobbleSword
PlayerInteractEvent abuse
Observed Behavior
Standing on pressure plate when having PlayerInteractEvent cancelled results in massive spam of PlayerInteractEvents.
Expected Behavior
Normal calling of events.
Steps To Reproduce
- Cancel PlayerInteractEvent.
- Step on a pressure plate.
Plugin List
No response
Server Version
Other
No response
Agreements
- [X] You were able to find this issue on the latest version of NachoSpigot.
- [X] You have confirmed that there aren’t any issues open regarding this bug.
- [X] You have confirmed that you are NOT using a fork of NachoSpigot in any way. YOUR changes are not OUR faults.
Server Version
Why don't you put your server version?
It's NachoSpigot, I thought it was obvious.
Server Version
Why don't you put your server version?
It's NachoSpigot, I thought it was obvious.
NachoSpigot is the server, not the server version.
Server Version
Why don't you put your server version?
It's NachoSpigot, I thought it was obvious.
NachoSpigot is the server, not the server version.
1.8.9
1.8.9
By the server version I mean the version of NachoSpigot, and in the issue template it states this.
1.8.9
By the server version I mean the version of NachoSpigot, and in the issue template it states this.
I thought this is irrelevant with this kind of issues.
https://github.com/CobbleSword/NachoSpigot/blob/a2e26e2bce25888c37d08a73139d03da371e666f/NachoSpigot-Server/src/main/java/net/minecraft/server/BlockPressurePlateBinary.java#L51 We can't do much without a performance drop since it has to check if the pressure plate is powered.
@Lucaskyy Close as a wontfix?
1.8.9
By the server version I mean the version of NachoSpigot, and in the issue template it states this.
I thought this is irrelevant with this kind of issues.
It's not :) We use it to identify on which commit you are. It's really handy for us, so it would be appreciated if you can add it if you create an issue.
1.8.9
By the server version I mean the version of NachoSpigot, and in the issue template it states this.
I thought this is irrelevant with this kind of issues.
It's not :) We use it to identify on which commit you are. It's really handy for us, so it would be appreciated if you can add it if you create an issue.
This wasn't touched in any commit, so I don't really think that matters in this issue.
https://github.com/CobbleSword/NachoSpigot/blob/a2e26e2bce25888c37d08a73139d03da371e666f/NachoSpigot-Server/src/main/java/net/minecraft/server/BlockPressurePlateBinary.java#L51
We can't do much without a performance drop since it has to check if the pressure plate is powered. @Lucaskyy Close as a wontfix?
It depends. Is Reflection invoking (caused by the event firing) better performant than a check for this? And can we stop the check from being spammed too?
1.8.9
By the server version I mean the version of NachoSpigot, and in the issue template it states this.
I thought this is irrelevant with this kind of issues.
It's not :) We use it to identify on which commit you are. It's really handy for us, so it would be appreciated if you can add it if you create an issue.
This wasn't touched in any commit, so I don't really think that matters in this issue.
Even though it doesn't matter for this issue, it might for another issue. It's not that hard to add the version, so please next time just add it.
It depends. Is Reflection invoking (caused by the event firing) better performant than a check for this? And can we stop the check from being spammed too?
Good point, I was just thinking because we'd have to save the last event and when it happened.
Maybe we can do the check about registed listeners != 0 and call the event, if plugins aren't listening that event, it will not fire and will save cpu usage
I'm going to make this an enhancement instead since it's not necessarily a bug.