NachoSpigot icon indicating copy to clipboard operation
NachoSpigot copied to clipboard

use-hopper-check breaks vanilla hoppers

Open wellnesscookie opened this issue 4 years ago • 8 comments

NachoSpigot did implement paper's patch for hopper optimisation, but didn't remove the 'use-hopper-check' feature in paper's config, nor code, as it was removed for knowing to cause issues with hopper behaviour.

There is no more reason to have it anymore, after the hopper optimisation patch was applied. Check out: https://github.com/PaperMC/Paper/issues/197

wellnesscookie avatar Oct 20 '21 11:10 wellnesscookie

In addition to explaining what's the issue:

  • Place hoppers as on picture below, hoppers are one on top of eachother, but every single one of them is poining in the chest aside. The expected behaviour is that they would first fill the bottom chest, then the chest above it, etc. And it works like so, until all of the chests get filled. Then, it starts acting weird. After emptying the chests, only the first chest on the top will start filling (the yellow one), even though the others below are empty. The direction and flow of itemstacks through hoppers is not respected and it really irritates our players.

The issue is same as: https://github.com/PaperMC/Paper/issues/299?fbclid=IwAR08cesFnaIaBvL3fx5fbL3OVUTp5fny23cDcW1UJ-ybAhkp1U9ScFvJ2rc , but Paper already referenced it to the hash197 (issue ID) as linked above. This one explains our problem better, but they kept the 197 open. unknown

wellnesscookie avatar Oct 20 '21 11:10 wellnesscookie

I'll try to take a look at removing it later today

CyberFlameGO avatar Oct 20 '21 19:10 CyberFlameGO

The problem, wherever it's coming from, is Nacho related. After switching to the latest version of Paper for 1.8.8 and turning off the use-hopper-check feature, this was not the case anymore. Even though we did disable that option on Nacho too, the bug was still there.

wellnesscookie avatar Oct 21 '21 13:10 wellnesscookie

The problem, wherever it's coming from, is Nacho related. After switching to the latest version of Paper for 1.8.8 and turning off the use-hopper-check feature, this was not the case anymore. Even though we did disable that option on Nacho too, the bug was still there.

Try testing it on TacoSpigot.

ghost avatar Nov 20 '21 15:11 ghost

Is this still an issue?

Sculas avatar Dec 17 '21 19:12 Sculas

Yes, at least on Nacho, but not on Paper. We would really love to test it with TacoSpigot, but our players would really hate to see the bug again, and since it does not occurs instantly and it's not possible for it to be tested whenever we want, we would have to make them test it. I am sorry, even though we would love to use Nacho/Burrito, we would not like to test it on production again.

We can try on our test server, but I am not sure if we will be able to reproduce it ourselves.

wellnesscookie avatar Dec 17 '21 20:12 wellnesscookie

Thanks for the response :) Since this was removed from Paper anyway, it makes sense for NachoSpigot to remove it too. So that's what we'll be doing soon, so hopefully, that will solve your issue.

Sculas avatar Dec 17 '21 21:12 Sculas

Reopen, #387 doesn’t fix this @Lucaskyy

ghost avatar Mar 29 '22 18:03 ghost