crmsh
crmsh copied to clipboard
Fix: cibconfig: Disable auto complete advised operation values when adding a rsc_template
Run
crm configure rsc_template dummy_template ocf:pacemaker:Dummy op monitor interval=12s
Then
crm configure primitive d1 @dummy_template params passwd=123
Got error
ERROR: None:None: got no meta-data, does this RA exist?
Solution: When adding a rsc_template as a primitive resource, should disable auto complete advised operation values
Fix #1438
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.58%. Comparing base (
bda8e3d) to head (51610c9). Report is 9 commits behind head on master.
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| integration | 54.31% <94.44%> (+0.35%) |
:arrow_up: |
| unit | 52.49% <88.88%> (+0.15%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| crmsh/cibconfig.py | 63.66% <100.00%> (+0.08%) |
:arrow_up: |
| crmsh/parse.py | 85.71% <100.00%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The regression tests fails. Do you need to rebase this?
This problem happens when executing the command instead of activating the completion. I think completion related code should not be called here. This patch does not fix the root cause.
This problem happens when executing the command instead of activating the completion. I think completion related code should not be called here. This patch does not fix the root cause.
No, it has no relation with completion here.
Maybe the var term complete_advised confuses?
That means to complete/add RA's advised operation values if user not specify them
See https://github.com/ClusterLabs/crmsh/pull/1038
Maybe the var term complete_advised confuses?
Yes, appearing together with "cli" and "parse", it is so confusing. Can you change to a clearer variable name?
Maybe the var term complete_advised confuses?
Yes, appearing together with "cli" and "parse", it is so confusing. Can you change to a clearer variable name?
Already changed the name of complete_advised
Regarding "cli" and "parse", since they are largely used and beyond the scope of this PR, I suggest to open an issue to trace?