CloudBot
CloudBot copied to clipboard
CloudBotIRC
Additional Foods Actions
Added rootbeer, beer, and cocktail to the foods subroutine. Root Beer creates random statement from list like taco. Beer selects a random beer from the list (pulled from Beer Advocates top 250 beers) and shows beer name, brewery, ABV, and style. Cocktail selects random cocktail, displays randomly generated statement with selected cocktai land includes link to cocktail recipe on webtender wiki.
Apparently, the maintainers have left the project for dead and have stopped reviewing pull requests. If you make a pull request on my fork, I'll go ahead and merge it.
https://github.com/tuxxy/CloudBot
This PR may have been overlooked or @lukeroge may have just not been able to pull it if he wanted to. Simply copy pasting the SAME comment into PRs and not reading about how the version structure works is unacceptable.
PRs that are requested into the master branch are generally ignored as I believe to be that its not meant to be directly PR'ed to that branch until such a time that it is deemed acceptable to do so, mainly by Luke himself.
Then comment on the PR and say that’s why you’re not pulling it, don’t just ignore it...
On Jun 13, 2016, at 20:34, Red_M [email protected] wrote:
This PR may have been overlooked or @lukeroge https://github.com/lukeroge may have just not been able to pull it if he wanted to. Simply copy pasting the SAME comment into PRs and not reading about how the version structure works is unacceptable.
PRs that are requested into the master branch are generally ignored as I believe to be that its not meant to be directly PR'ed to that branch until such a time that it is deemed acceptable to do so, mainly by Luke himself.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CloudBotIRC/CloudBot/pull/193#issuecomment-225764261, or mute the thread https://github.com/notifications/unsubscribe/ADbn7tdyCh4Fh4b18fuxIeq2jIDM8zlpks5qLhMogaJpZM4F-jWE.
In the sake of keeping the conversation in one stream please move it to PR #212
Opinions on this?
I can definitely merge, just wondering if the other contributors want to weigh in on if this is in scope of CloudBot.
Not sure personally, seems fine to me but i'd wait for luke to say something with this one. On 17 Jun 2016 9:33 AM, "Dabo Ross" [email protected] wrote:
Opinions on this?
I can definitely merge, just wondering if the other contributors want to weigh in on if this is in scope of CloudBot.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CloudBotIRC/CloudBot/pull/193#issuecomment-226643431, or mute the thread https://github.com/notifications/unsubscribe/ABZoEd6EYk1VdFGwZfUBUYMy2ApxUXQPks5qMd0ygaJpZM4F-jWE .
