click-ui icon indicating copy to clipboard operation
click-ui copied to clipboard

IconButton has 2 extra pixels because of the border

Open rndD opened this issue 9 months ago • 4 comments

Image

<IconButton> size xs should be 16x16 by design.

We can:

  • make border optional
  • remove border (why do we have it in the first place??
  • make icon smaller accordingly

rndD avatar Feb 11 '25 11:02 rndD

cc @crisalbu @ariser

rndD avatar Feb 11 '25 11:02 rndD

Blocks https://github.com/ClickHouse/control-plane/issues/13642

rndD avatar Feb 11 '25 11:02 rndD

The border is requried for e.g. danger type, it's visible in this case if we remove it, we need to replace it with box-shadow or perhaps outline, which don't take space probably easier to keep it

ariser avatar Feb 11 '25 11:02 ariser

It appears that we just need to reduce the padding by 1px - that should fix it.

crisalbu avatar Feb 12 '25 12:02 crisalbu