ClickHouse
Remove sorting from query plan stream properties
Changelog category (leave one):
- Not for changelog (changelog entry is not required)
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Because it is too complicated to support.
Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/
CI Settings (Only check the boxes if you know what you are doing):
- [ ] Allow: All Required Checks
- [ ] Allow: Stateless tests
- [ ] Allow: Stateful tests
- [ ] Allow: Integration Tests
- [ ] Allow: Performance tests
- [ ] Allow: All Builds
- [ ] Allow: batch 1, 2 for multi-batch jobs
- [ ] Allow: batch 3, 4, 5, 6 for multi-batch jobs
- [ ] Exclude: Style check
- [ ] Exclude: Fast test
- [ ] Exclude: All with ASAN
- [ ] Exclude: All with TSAN, MSAN, UBSAN, Coverage
- [ ] Exclude: All with aarch64
- [ ] Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
- [ ] Exclude: AST fuzzers
- [ ] Do not test
- [x] Woolen Wolfdog
- [ ] Upload binaries for special builds
- [x] Disable merge-commit
- [ ] Disable CI cache
This is an automated comment for commit dfe8eb059c9d244317436c076d2a39781d345b61 with description of existing statuses. It's updated for the latest CI running
❌ Click here to open a full report in a separate page
| Check name | Description | Status |
|---|---|---|
| Integration tests | The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests | ❌ failure |
Successful checks
| Check name | Description | Status |
|---|---|---|
| AST fuzzer | Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help | ✅ success |
| Builds | There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS | ✅ success |
| ClickBench | Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table | ✅ success |
| Compatibility check | Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help | ✅ success |
| Docker keeper image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Docker server image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Docs check | Builds and tests the documentation | ✅ success |
| Fast test | Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here | ✅ success |
| Flaky tests | Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc | ✅ success |
| Install packages | Checks that the built packages are installable in a clear environment | ✅ success |
| Performance Comparison | Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests | ✅ success |
| Stateful tests | Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ✅ success |
| Stateless tests | Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ✅ success |
| Stress test | Runs stateless functional tests concurrently from several clients to detect concurrency-related errors | ✅ success |
| Style check | Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report | ✅ success |
| Unit tests | Runs the unit tests for different release types | ✅ success |
| Upgrade check | Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts | ✅ success |
This PR fixed push_down_limit performance test but broke optimize_sorting_for_input_stream.
Ok, it is only with optimize_read_in_order=0, which is 1 by default.
~~Will fix it later.~~
UPD I have decided not to fix two failed tests. They are based on the assumption that reading from MergeTree returns chunks ordered by sorting key
Sorting (Chunk): CounterID ASC, EventDate ASC
I believe this assumption is not valid (or, at least, very fragile). We can easily have a situation when the reading task reads from 2 parts and forms a single chunk from it. We can enforce returning sorted chunks if needed. But why do we need it if we already have a read-in-order feature enabled by default?