ClickHouse icon indicating copy to clipboard operation
ClickHouse copied to clipboard

Fix inconsistent formatting for `GRANT CURRENT GRANTS`

Open pufit opened this issue 1 year ago • 6 comments

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes https://github.com/ClickHouse/ClickHouse/issues/67651

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • [ ] Allow: All Required Checks
  • [ ] Allow: Stateless tests
  • [ ] Allow: Stateful tests
  • [ ] Allow: Integration Tests
  • [ ] Allow: Performance tests
  • [ ] Allow: All Builds
  • [ ] Allow: batch 1, 2 for multi-batch jobs
  • [ ] Allow: batch 3, 4, 5, 6 for multi-batch jobs

  • [ ] Exclude: Style check
  • [ ] Exclude: Fast test
  • [ ] Exclude: All with ASAN
  • [ ] Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • [ ] Exclude: All with aarch64, release, debug

  • [ ] Do not test
  • [ ] Woolen Wolfdog
  • [ ] Upload binaries for special builds
  • [ ] Disable merge-commit
  • [ ] Disable CI cache

pufit avatar Aug 02 '24 04:08 pufit

This is an automated comment for commit 04438784e2178820537c65b66b5a8341f3d63b8d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

robot-clickhouse-ci-2 avatar Aug 02 '24 04:08 robot-clickhouse-ci-2

Add a test.

There is one already, and it's failing without this fix https://s3.amazonaws.com/clickhouse-test-reports/65277/fa6564dbe32033af3aa0693d07d1b9a645adfa40/integration_tests_flaky_check__asan_.html

pufit avatar Aug 02 '24 22:08 pufit

That test is from a pull request that is not merged yet. Let's add a simple, functional test.

alexey-milovidov avatar Aug 03 '24 00:08 alexey-milovidov

That test is from a pull request that is not merged yet. Let's add a simple, functional test.

Below should be enough, just tested locally

DROP USER IF EXISTS user_03214;

CREATE USER user_03214;

GRANT CURRENT GRANTS(NONE ON *.*) TO user_03214;

arthurpassos avatar Aug 03 '24 00:08 arthurpassos

Yes, see similar *inconsistent_formatting*.sh tests, using clickhouse-format.

alexey-milovidov avatar Aug 03 '24 01:08 alexey-milovidov

That test is from a pull request that is not merged yet.

No, it's an old test https://github.com/ClickHouse/ClickHouse/blob/master/tests/integration/test_grant_and_revoke/test_with_table_engine_grant.py#L615 But I can add a simple .sh test nevertheless

pufit avatar Aug 03 '24 04:08 pufit

03002_part_log_rmt_fetch_merge_error - fixed here https://github.com/ClickHouse/ClickHouse/pull/67960

pufit avatar Aug 13 '24 03:08 pufit