ClickHouse
Fix cluster() for inter-server secret (preserve initial user as before)
Changelog category (leave one):
- Bug Fix (user-visible misbehavior in an official stable release)
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix cluster() for inter-server secret (preserve initial user as before)
The behaviour of cluster() with inter-server secret had been changed in #63013, after it started to use "default" user, and this introduces a regression.
The intention of that patch was to adjust only remote(), since it only it accept custom user, which should be ignored.
Fixes: https://github.com/ClickHouse/ClickHouse/issues/66287 (cc @den-crane @pufit ) Fixes: https://github.com/ClickHouse/ClickHouse/issues/66352 (cc @canhld94 ) Fixes: #63013
This is an automated comment for commit bdfaffa9d74b0405ea619330215e6c71f0b6976a with description of existing statuses. It's updated for the latest CI running
❌ Click here to open a full report in a separate page
| Check name | Description | Status |
|---|---|---|
| Stateless tests | Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ❌ failure |
Successful checks
| Check name | Description | Status |
|---|---|---|
| AST fuzzer | Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help | ✅ success |
| Bugfix validation | Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch | ✅ success |
| Builds | There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS | ✅ success |
| ClickBench | Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table | ✅ success |
| Compatibility check | Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help | ✅ success |
| Docker keeper image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Docker server image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Fast test | Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here | ✅ success |
| Flaky tests | Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc | ✅ success |
| Install packages | Checks that the built packages are installable in a clear environment | ✅ success |
| Integration tests | The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests | ✅ success |
| Performance Comparison | Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests | ✅ success |
| Stateful tests | Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ✅ success |
| Stress test | Runs stateless functional tests concurrently from several clients to detect concurrency-related errors | ✅ success |
| Style check | Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report | ✅ success |
| Unit tests | Runs the unit tests for different release types | ✅ success |
| Upgrade check | Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts | ✅ success |
Tests are not finished, fail: 6, passed: 1419, skipped
clickhouse-server: /build/src/Databases/DDLLoadingDependencyVisitor.cpp:216: static void DB::DDLLoadingDependencyVisitor::extractTableNameFromArgument(const ASTFunction &, Data &, size_t): Assertion `false' failed.
This problem had been fixed already long time ago, will do a rebase
@pufit any clue why cloud fork sync failed? Does something required to be done from my side?
https://s3.amazonaws.com/clickhouse-test-reports/66364/189d1848488bb3e126df3172ac1ca18a2e315af9/integration_tests__asan__old_analyzer__[5_6].html
Fixed in da3a37c56167