ClickHouse icon indicating copy to clipboard operation
ClickHouse copied to clipboard

[WIP] setting to use Variant data type during schema inference

Open Blargian opened this issue 1 year ago • 3 comments

Closes #62814. Adds a setting input_format_json_infer_variant_from_multi_type_array.

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Adds a setting input_format_json_infer_variant_from_multi_type_array which one set true allows Variant type to be inferred during schema inference when column/array has values with different types.

Documentation entry for user-facing changes

  • [ ] Documentation is written (mandatory for new features)

Blargian avatar May 14 '24 19:05 Blargian

This is an automated comment for commit ae389d14ee65ff5fea3543868b6b161f9fcb806e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ error
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

robot-clickhouse-ci-2 avatar May 14 '24 20:05 robot-clickhouse-ci-2

Maybe input_format_json_infer_variant_from_multi_type_array?

alexey-milovidov avatar May 15 '24 01:05 alexey-milovidov

@Avogar mostly working, except for the first example you gave Array(Variant(Int64, String, Tuple(a Nullable(Int64)))) I am getting instead Array(Variant(Int64, String, Tuple(a Int64))) - I still need to fix that.

Blargian avatar May 15 '24 19:05 Blargian

Stateful tests (asan) — Tests are not finished, fail: 1, passed: 130, skipped: 1 - https://github.com/ClickHouse/ClickHouse/issues/57508

Avogar avatar Jul 16 '24 19:07 Avogar

Every time I want to merge this PR there is a conflict in the SettingsChangesHistory ... Sorry for that, will try to merge soon

Avogar avatar Jul 29 '24 11:07 Avogar