TOTALS and BY combinators
Changelog category (leave one):
- New Feature
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for TOTALS and BY combinators for aggregate functions. They allow to compute aggregations with rollups without using window functions or grouping sets.
Documentation entry for user-facing changes
- [ ] Documentation is written (mandatory for new features)
Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/
Modify your CI run
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
- [ ] Fast test
- [ ] Integration Tests
- [ ] Stateless tests
- [ ] Stateful tests
- [ ] Unit tests
- [ ] Performance tests
- [ ] All with ASAN
- [ ] All with TSAN
- [ ] All with Analyzer
- [ ] All with Azure
- [ ] Add your option here
Exclude tests:
- [ ] Fast test
- [ ] Integration Tests
- [ ] Stateless tests
- [ ] Stateful tests
- [ ] Performance tests
- [ ] All with ASAN
- [ ] All with TSAN
- [ ] All with MSAN
- [ ] All with UBSAN
- [ ] All with Coverage
- [ ] All with Aarch64
- [ ] Add your option here
Extra options:
- [ ] do not test (only style check)
- [ ] disable merge-commit (no merge from master before tests)
- [ ] disable CI cache (job reuse)
Only specified batches in multi-batch jobs:
- [ ] 1
- [ ] 2
- [ ] 3
- [ ] 4
This is an automatic comment. The PR descriptions does not match the template.
Please, edit it accordingly.
The error is: Changelog entry required for category 'New Feature'
Not working yet
This is an automated comment for commit a5da17b8f920174489258a60f00c13a3dccf3888 with description of existing statuses. It's updated for the latest CI running
❌ Click here to open a full report in a separate page
| Check name | Description | Status |
|---|---|---|
| Performance Comparison | Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests | ❌ failure |
Successful checks
| Check name | Description | Status |
|---|---|---|
| AST fuzzer | Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help | ✅ success |
| Builds | There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS | ✅ success |
| ClickBench | Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table | ✅ success |
| Compatibility check | Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help | ✅ success |
| Docker keeper image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Docker server image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Docs check | Builds and tests the documentation | ✅ success |
| Fast test | Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here | ✅ success |
| Flaky tests | Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc | ✅ success |
| Install packages | Checks that the built packages are installable in a clear environment | ✅ success |
| Integration tests | The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests | ✅ success |
| Stateful tests | Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ✅ success |
| Stateless tests | Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ✅ success |
| Stress test | Runs stateless functional tests concurrently from several clients to detect concurrency-related errors | ✅ success |
| Style check | Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report | ✅ success |
| Unit tests | Runs the unit tests for different release types | ✅ success |
| Upgrade check | Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts | ✅ success |
There are a couple of flaws here that I'm going to fix soon:
- Extra space before TOTALS and BY when using EXPLAIN SYNTAX
- Incorrect column names in the query result
Otherwise it's ready for review
Ready for review