ClickHouse icon indicating copy to clipboard operation
ClickHouse copied to clipboard

group_by_use_nulls strikes back

Open KochetovNicolai opened this issue 1 year ago • 5 comments

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Closes https://github.com/ClickHouse/ClickHouse/issues/62661

KochetovNicolai avatar Apr 24 '24 16:04 KochetovNicolai

This is an automated comment for commit bb9652998b77a9150cc04e61cbef4f5cac291855 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

robot-clickhouse avatar Apr 24 '24 16:04 robot-clickhouse

SELECT
    a,
    b,
    cramersVBiasCorrected(a, b)
FROM numbers(3)
GROUP BY
    number AS a,
    number + number AS b
    WITH CUBE
SETTINGS group_by_use_nulls = 1;

KochetovNicolai avatar Apr 24 '24 17:04 KochetovNicolai

AST fuzzer (asan) - unclear; no messages in log; the last query works fine locally AST fuzzer (ubsan) - SELECT arrayMap(x -> '.', range(number % 10)) AS k FROM remote('127.0.0.{2,3}', numbers(1e6)) GROUP BY GROUPING SETS ((k)) settings group_by_use_nulls=1 Stress test (tsan) - race in async inserts

KochetovNicolai avatar May 07 '24 12:05 KochetovNicolai

#62661 seems to be working in the master. What does this PR fix?

novikd avatar May 08 '24 12:05 novikd

This PR just adds a test, and tries to fix all fuzzings on top.

KochetovNicolai avatar May 08 '24 14:05 KochetovNicolai

image Finally

KochetovNicolai avatar May 13 '24 14:05 KochetovNicolai

03145_non_loaded_projection_backup was flaky when merged: https://s3.amazonaws.com/clickhouse-test-reports/63426/ba4f5f9b3fe74d44295633995033c9d484b8a9c6/stateless_tests_flaky_check__asan_.html 02479_mysql_connect_to_self is flaky as well

KochetovNicolai avatar May 13 '24 16:05 KochetovNicolai