Session pool
https://github.com/ClickHouse/ClickHouse/issues/50217
This PR makes http/https connections reusable for all uses cases.
the main changes here are:
src/Common/HostResolvePool.{h.cpp}
That class resolves host into multiply addresses Features:
- balance address usage.
selectBest()chooses the address by random with weights. The more ip is used the lesser weight it has. When new address is happened, it takes more weight. But still not all requests are assigned to the new address. - join resolve results. In case when host is resolved into different set of addresses, this class join all that addresses and use them. An address expires after
history_time. - failed address pessimization. If an address marked with
setFail()it is marked as faulty. Such address won't be selected until either a) it still occurs in resolve set afterhistory_time or b) all other addresses are pessimized as well. - resolve schedule. Addresses are resolved through
DB::DNSResolver::instance(). Usually it does not happen more often than once inhistory_time. But also new resolve performed eachsetFail()call.
src/Common/ConnectionPool.{h,cpp}
That classes manage connections to the endpoint Features:
- it uses HostResolvePool for address selecting. See Common/HostResolvePool.h for more info.
- it minimizes number of
Session::connect()/Session::reconnect()calls - stores only connected and ready to use sessions
- connection could be reused even when limits are reached
- soft limit, warn limit, hard limit
Session::reconnect()uses the pool as well- comprehensive sensors
- session is reused according its inner state, automatically
- sensors and limits are groped by the logical source of connection: disks, storages, http (the rest).
src/IO/ReadWriteBufferFromHTTP.h
I have removed all unnecessary complications from it. Make more straightforward errors/retries handling.
Changelog category (leave one):
- Not for changelog (changelog entry is not required)
In general It works great. Almost all connections are reused automatically. Even when response is 3xx or 4xx.
This is an automated comment for commit 77c5de700f62451c6f2cf55620d9522832b5d56b with description of existing statuses. It's updated for the latest CI running
❌ Click here to open a full report in a separate page
Successful checks
| Check name | Description | Status |
|---|---|---|
| A Sync | There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS | ✅ success |
| AST fuzzer | Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help | ✅ success |
| ClickBench | Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table | ✅ success |
| ClickHouse build check | Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process | ✅ success |
| Compatibility check | Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help | ✅ success |
| Docker keeper image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Docker server image | The check to build and optionally push the mentioned image to docker hub | ✅ success |
| Docs check | Builds and tests the documentation | ✅ success |
| Fast test | Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here | ✅ success |
| Flaky tests | Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc | ✅ success |
| Install packages | Checks that the built packages are installable in a clear environment | ✅ success |
| Integration tests | The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests | ✅ success |
| Mergeable Check | Checks if all other necessary checks are successful | ✅ success |
| PR Check | There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS | ✅ success |
| Performance Comparison | Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests | ✅ success |
| Stateful tests | Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ✅ success |
| Stress test | Runs stateless functional tests concurrently from several clients to detect concurrency-related errors | ✅ success |
| Style check | Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report | ✅ success |
| Unit tests | Runs the unit tests for different release types | ✅ success |
| Upgrade check | Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts | ✅ success |
| Check name | Description | Status |
|---|---|---|
| CI running | A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR | ⏳ pending |
| Stateless tests | Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc | ❌ failure |
Found a bug:
A lot of files are read with default initialized read settings, files like format_version.txt, columns.txt, metadata_version.txt,... and indexes like primary.cidx. By default read settings has http_max_tries = 1, meanwhile if read settings created from default context it would be initializes with http_max_tries = 10.
As a quick fix I've made defaults corresponding.
It happens here: https://github.com/ClickHouse/ClickHouse/blob/a1d1f76f67ab29c759374cf5a51b2e1fecf933f8/src/Storages/MergeTree/PartMetadataManagerOrdinary.cpp#L11-L14
Failed tests https://github.com/ClickHouse/ClickHouse/issues/60625 https://github.com/ClickHouse/ClickHouse/issues/61090