climt icon indicating copy to clipboard operation
climt copied to clipboard

Addition of SimpleBoundaryLayer component

Open Ai33L opened this issue 3 years ago • 4 comments

Ai33L avatar Nov 08 '21 18:11 Ai33L

@JoyMonteiro the windows tests seem to be failing when compiling the radiation code, which as far as I can tell isn't changed by this PR, and the mac tests seem to have a problem with the openblas install. Do you have any cycles to look at this?

mcgibbon avatar Nov 08 '21 19:11 mcgibbon

I will have some time next week to look into this. The windows error seems to be fixable https://stackoverflow.com/questions/43152633/invalid-register-for-seh-savexmm-in-cygwin I'll check the mac error later.

JoyMonteiro avatar Nov 09 '21 05:11 JoyMonteiro

@Ai33L could you replace this line if [ ! -d $(BLAS_DIR) ]; then tar -xvzf $(BLAS_GZ) > log 2>&1; fi; cd $(BLAS_DIR); CFLAGS=$(CLIMT_CFLAGS) make NO_SHARED=1 NO_LAPACK=0 > log 2>&1 ; make PREFIX=$(BASE_DIR) NO_SHARED=1 NO_LAPACK=0 install > log.install.blas 2>&1 ; cp ../lib/libopenblas.a $(LIB_DIR)

with if [ ! -d $(BLAS_DIR) ]; then tar -xvzf $(BLAS_GZ) > log 2>&1; fi; cd $(BLAS_DIR); CFLAGS=$(CLIMT_CFLAGS) make NO_SHARED=1 NO_LAPACK=0 > log 2>&1 ; cat log; make PREFIX=$(BASE_DIR) NO_SHARED=1 NO_LAPACK=0 install > log.install.blas 2>&1 ; cp ../lib/libopenblas.a $(LIB_DIR)

at https://github.com/CliMT/climt/blob/9dbe7fb8c59e36705d224f685cc311dffa17b96d/climt/_lib/Makefile#L64

This will give us some output to debug the mac build with.

JoyMonteiro avatar Nov 09 '21 05:11 JoyMonteiro

@Ai33L could you replace this line if [ ! -d $(BLAS_DIR) ]; then tar -xvzf $(BLAS_GZ) > log 2>&1; fi; cd $(BLAS_DIR); CFLAGS=$(CLIMT_CFLAGS) make NO_SHARED=1 NO_LAPACK=0 > log 2>&1 ; make PREFIX=$(BASE_DIR) NO_SHARED=1 NO_LAPACK=0 install > log.install.blas 2>&1 ; cp ../lib/libopenblas.a $(LIB_DIR)

with if [ ! -d $(BLAS_DIR) ]; then tar -xvzf $(BLAS_GZ) > log 2>&1; fi; cd $(BLAS_DIR); CFLAGS=$(CLIMT_CFLAGS) make NO_SHARED=1 NO_LAPACK=0 > log 2>&1 ; cat log; make PREFIX=$(BASE_DIR) NO_SHARED=1 NO_LAPACK=0 install > log.install.blas 2>&1 ; cp ../lib/libopenblas.a $(LIB_DIR)

at

https://github.com/CliMT/climt/blob/9dbe7fb8c59e36705d224f685cc311dffa17b96d/climt/_lib/Makefile#L64

This will give us some output to debug the mac build with.

I have made this change.

Ai33L avatar Nov 09 '21 06:11 Ai33L