ClimaParams.jl icon indicating copy to clipboard operation
ClimaParams.jl copied to clipboard

Updated reference temperature to reflect dycore manuscript

Open ray-chew opened this issue 2 months ago • 3 comments

Purpose and content

In the manuscript, we changed temperature_surface_reference to 288 K and temperature_min_reference to 215 K, respectively. This PR synchronises the default parameters with those in the manuscript.

To-do

Content


  • [x] I have read and checked the items on the review checklist.

ray-chew avatar Sep 24 '25 22:09 ray-chew

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.76%. Comparing base (0031b92) to head (f739f9e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files           1        1           
  Lines         130      130           
=======================================
  Hits          118      118           
  Misses         12       12           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 24 '25 22:09 codecov[bot]

@nefrathenrici ClimaAtmos Project.toml currently tracks ClimaParams v1 - should this be more restrictive ?

akshaysridhar avatar Sep 24 '25 22:09 akshaysridhar

Thank you! Could you update the NEWS.md as well?

Oh, thanks for reminding me! Done. :)

ray-chew avatar Sep 25 '25 22:09 ray-chew