Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

[Innawood] Fix scrap from hematite giving too much scrap

Open Light-Wave opened this issue 1 year ago • 5 comments

Summary

Bugfixes "[Innawood] Fix scrap from hematite giving too much scrap"

Purpose of change

Smelting hematite into scrap metal accidentally gave you twice as much metal as intended Fixes #78149

Describe the solution

Cut the result_mult in half

Describe alternatives you've considered

Make sure all the variant recipes of smelting hematite gives exactly the same amount of metal

Testing

Loaded up Innawwod and crafted all three variants of the recipe to check how much metal you actually get

Additional context

There are three ways to smelt hematite in Innawood: To scrap: Previously 150 scrap, now 74 scrap To lumps: 3 lumps, 2 chunks, equivalent to 70 scrap To chunks: 15 chunks, equivalent to 75 scrap

Light-Wave avatar Nov 26 '24 09:11 Light-Wave

Why are you using result_mult anyways? You could just use charges to specify the amount produced more consistently.

NetSysFire avatar Nov 26 '24 13:11 NetSysFire

Why are you using result_mult anyways? You could just use charges to specify the amount produced more consistently.

I'm just tweaking what Karol1223 coded ¯_(ツ)_/¯

Light-Wave avatar Nov 28 '24 18:11 Light-Wave

Whyy @Karol1223, why did you use result_mult instead of just charges? Only thing I can imagine is to better account for the amount when a single chunk of hematite can not be processed into an even number of resources.

NetSysFire avatar Nov 28 '24 18:11 NetSysFire

I don't fucking know man it was over a year ago and I had minecraft steve wannabes knocking on my door because I changed blacksmithing recipes to not let them punch cars to get a whole blacksmithing setup in their garage

Karol1223 avatar Nov 28 '24 18:11 Karol1223

This sounds like it really should be using charges, maybe you confused charges and result_mult back then.

NetSysFire avatar Nov 28 '24 22:11 NetSysFire

Not sure what the correct answer is here but this at least makes some improvement

Maleclypse avatar Dec 12 '24 22:12 Maleclypse