Hats with pockets

[AudBobb]

Summary

Content "Two new hats featuring pockets"

Purpose of change

There was a distinct lack of hats capable of holding solid items in the wake of #77243. This PR aims to fix this glaring issue.

Describe the solution

Added two new hats featuring pockets, the stylish Fanny Cap, perfect for summer time, and an Ushanka with a pocket built into each ear flap, great for those cold winter months.

Describe alternatives you've considered

Testing

Checked that they recipes showed in game. Both new items are present.

Additional context

You're welcome Horis, live out your best ammo storing hat life.

Remaking this because visual studio auto formatted the files when I opened them, causing a massive mess

[github-actions[bot]]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• fur hat with pocketss

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[esotericist]

the fanny cap is ridiculous, and absolutely not acceptable for merging.

the ushanka pockets are very unclear on how they're intended to work, and without a reference i suspect the answer is "they probably wouldn't as implemented".

it's very obvious this PR is attempting to fill a perceived gap in functionality, without asking the question of "does this make sense" or "are these things really stuff that should be around". that's not how we do things here.

select reasonable, modestly widespread examples of head-mounted storage, or this isn't going to go anywhere productive.

[AudBobb]

I mean, fanny pack hats are actually a thing in the real world, and I don't see why a survivor couldn't make one if they wanted to, but if the PR is denied, then so be it, I'm not really married to the items, just made this in response to the additional context on the linked PR, 🤷

As for the ushanka pockets, the are just pockets sewn into the ear flaps of an ushanka. Plenty of real estate there.

[Holli-Git]

The only real evidence I could find of them being "a real thing" is a one-off novelty/gag gift on Amazon and I don't think those would exist in nearly enough quantities to be reasonable to see in CDDA. The amount of storage is also pretty generous. As for the ushanka, I doubt that it would last very long as pockets. A hat with small pockets for stuff like bandages would be a more than welcome addition, but this seems to be quite a stretch. Closing PR

[NetSysFire]

For the reference, I meant something thats not a silly gag. See https://en.wikipedia.org/wiki/Head-carrying.

[AudBobb]

:shrug: I don't really understand what how widespread in popularity them being has to do with this change, I wasn't suggesting they be added to loot pools to spawn in the world, but rather adding a recipe for a survivor to sew a pouch onto a hat. I could go and do that right now myself. And admittedly yes, the volume was probably a bit large, I didn't change it from what the ingredient used when I probably should have. But it's really not a hill I care to fight on, I probably wouldn't have used the item anyways, just figured I'd submit the request since at least one person out there seemed interested.

For the reference, I meant something thats not a silly gag. See https://en.wikipedia.org/wiki/Head-carrying.

Fair enough. I just assumed based on context in the post that what was being suggested was a substitute for what was being removed through the bug fix of the drinking cap.