Cataclysm-DDA icon indicating copy to clipboard operation
Cataclysm-DDA copied to clipboard

Behavior of attachable ear muffs with army helmet is incredibly inconsistent

Open HotSake opened this issue 1 year ago • 4 comments

Describe the bug

The deafened state is inconsistently applied, removed, or otherwise toggled by activating the attachable earmuffs item in the ear pocket of a worn army helmet. Upon first inserting the ear muffs into the army helmet's pocket, they have no effect. About 50% of the time, after activating them (changing them to the ON state), the PC is still not deafened and can converse with NPCs. Activating them a second time (removing ON from the item name), the PC will now be deafened and unable to converse. From here, repeated activations will usually toggle the deaf state, regardless of the item state. Removing the ear muffs from the pocket or dropping them will always clear the deaf state.

Additionally, the attachable ear muffs can be activated while not in a helmet pocket, toggling their ON/OFF state and printing the message in the log about pressing them to your ears or moving them away. This does not affect the deaf state, but is at best a misleading log message, and may be related to the bug.

Attach save file

Cannon Town-trimmed.tar.gz

Steps to reproduce

  1. Check the activation state of the attachable ear muffs in the provided save file.
  2. Attempt to converse with the adjacent shelter NPC.
  3. Repeatedly activate the ear muffs to toggle their state, and attempt to converse with the NPC after each activation.
  4. While deafened, remove the ear muffs from the army helmet pocket by (U)nloading the helmet.
  5. Attempt to converse with the NPC.
  6. Examine the helmet and re-(I)nsert the attachable ear muffs.
  7. Attempt to converse with the NPC again.
  8. Continue activating the ear muffs and attempting to converse with the NPC.
  9. Remove the ear muffs from the helmet pocket so they are in your inventory in a pocket of the backpack.
  10. Activate the ear muffs so that they are in the ON state while unattached.
  11. Reinsert the ear muffs into the helmet pocket.
  12. Attempt to converse with the NPC.
  13. Toggle the ear muffs a few more times, attempting to converse with the NPC each time.

Expected behavior

The attachable ear muffs should always deafen the character when in a helmet ear pocket and in the ON state. They should never deafen the character while in the OFF state. They should not be activatable while not in a helmet ear pocket, or doing so should first insert them into a helmet ear pocket. If removed from a helmet ear pocket while in the ON state, they should revert to the OFF state.

Screenshots

Tom _2024-08-25T23-49-26

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4780 (22H2)
  • Game Version: d6ec466 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Portal Storms Ignore NPCs [personal_portal_storms], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions] ]

Additional context

No response

HotSake avatar Aug 26 '24 04:08 HotSake

It seems someone is trying to get people to download some unknown file (one and two posts above), using various usernames. I'd suggest NOT downloading it unless you have a contained environment where you can safely examine what it is.

PatrikLundell avatar Aug 26 '24 08:08 PatrikLundell

This is global github spam. If you are interested in the particular malware, see https://www.virustotal.com/gui/file/b127de888f09ce23937c12b7fccfa47a8f48312b0e43eb59b6243f665c6d366a, https://malpedia.caad.fkie.fraunhofer.de/details/win.lumma and https://www.broadcom.com/support/security-center/protection-bulletin/lumma-stealer-via-social-media-and-ai-related-lure

Edit: Also please ping me so I can hide any that havent been hidden yet. Github needs to address this globally.

NetSysFire avatar Aug 26 '24 10:08 NetSysFire

Can confirm this in 0.G-stable, but not in 0.H-rc or current experimental I think it was fixed by #64949

HadeanLake avatar Aug 31 '24 14:08 HadeanLake